Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty console.log calls makes the logging untidy #14

Open
gnithin opened this issue Dec 8, 2015 · 1 comment
Open

Empty console.log calls makes the logging untidy #14

gnithin opened this issue Dec 8, 2015 · 1 comment

Comments

@gnithin
Copy link
Contributor

gnithin commented Dec 8, 2015

Adding empty console.log calls makess the logging untidy.
The problem is that empty tags are being inserted, which is been accounted for in the odd-even check (logEl.children.length % 2 ?)

The solution would be either empty elements need to be logged and the odd-event color match or empty elements being skipped altogther.


selection_002

vivekannan added a commit to vivekannan/screenlog.js that referenced this issue Dec 9, 2015
@vivekannan
Copy link
Contributor

vivekannan commented Dec 9, 2015

Adding min-height to the element's css solves the issue.

Update: This issue is fixed and can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants