Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC State parameter not present in Oauth2 authorisation request #382

Open
AlexGiroud opened this issue Oct 23, 2023 · 1 comment
Open

Comments

@AlexGiroud
Copy link

I was trying to use Chiefonboarding with our OIDC provider and was stuck getting an error : The authentication request has an invalid 'state' parameter.

After some digging, I've found that this parameter is not required in OIDC spec but recommended (to mitigate CSRF attacks) and some OIDC providers require it (like Okta for example https://developer.okta.com/docs/reference/api/oidc/#request-parameters)

It would be nice to have it for the added security and to broaden OIDC provider options

@AlexGiroud AlexGiroud changed the title Oauth2 State parameter not present in OIDC authorisation request OIDC State parameter not present in Oauth2 authorisation request Oct 23, 2023
@GDay
Copy link
Member

GDay commented Oct 23, 2023

Good point. Probably a good idea to just migrate to allauth to get this and potential other issues resolved. It's currently a custom setup and I would likely be more at ease with a battle tested package to avoid having more things come up.
I will add it to my list of things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants