Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF embed viewer #307

Open
joenilson opened this issue May 18, 2023 · 2 comments
Open

Add PDF embed viewer #307

joenilson opened this issue May 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@joenilson
Copy link
Contributor

As there is a viewer for videos uploaded, there must to be a viewer for pdf uploaded.

This is add to _content.html the pdf embed or object tag in the attached if.

Working with this to do a PR.

@GDay
Copy link
Member

GDay commented May 18, 2023

Interesting idea. I only use FF and it has a build-in pdf reader when I open PDF files. I am not entirely sure about other browsers, but I wonder if embedding PDF files would add a lot of value.

When I think of a PDF file, I generally think of large text documents or forms that need to be filled in. So I am not sure if embedding these would work that well, since the PDF would show up a lot smaller inline.

@joenilson
Copy link
Contributor Author

In this case, when you have a new hire you want them to see your privacy policy or some document with the company principles or ISO certification information.

This documents commonly are one or two pages, as they could be controlled documents can't converted as images and are required that the new hire see and acknowledge read it.

That is why embed a pdf file is functional and it allows to the human resources department to incrust his documents without converting or sharing externally.

@GDay GDay added the enhancement New feature or request label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants