Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuum method names need clarity #138

Open
wtbarnes opened this issue Jun 19, 2017 · 1 comment
Open

Continuum method names need clarity #138

wtbarnes opened this issue Jun 19, 2017 · 1 comment

Comments

@wtbarnes
Copy link
Member

Per the discussion in Issue #134, the method names in the Continuum module need to be cleaned up a bit. Currently, nearly all of them are prepended with calculate (e.g. calculate_free_bound_emission) though this is a bit annoying when searching for a particular method name. To help users identify method names easier, the calculate should be moved to the end of the name. This also helps autocomplete (e.g. in the Jupyter notebook) be more useful. Note that all of the names and calls to these methods in the Continuum module will need to be changed in addition to any other places where a Continuum class is instantiated, e.g. Spectrum, radLoss

@kdere
Copy link
Contributor

kdere commented Jun 20, 2017

sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants