Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared peerDependency on prop-types #148

Open
TheLarkInn opened this issue Dec 1, 2022 · 0 comments
Open

Undeclared peerDependency on prop-types #148

TheLarkInn opened this issue Dec 1, 2022 · 0 comments

Comments

@TheLarkInn
Copy link

Looking at:

import PropTypes from 'prop-types';

prop-types is explicitly used inside of the production code of this package, however it is only declared as a devDependency. This needs to be declared as a peerDependency if users are expected to "bring-their-own" version of prop-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant