Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillUpdate has been renamed, #100

Open
payandeh opened this issue Nov 7, 2019 · 9 comments
Open

componentWillUpdate has been renamed, #100

payandeh opened this issue Nov 7, 2019 · 9 comments

Comments

@payandeh
Copy link

payandeh commented Nov 7, 2019

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: Lottie

@mrados7
Copy link

mrados7 commented Nov 12, 2019

Yep, someone needs to fix this :/

@thomazcapra
Copy link

Is this repo being mantained by someone?

@graemeblackwood
Copy link

The owner of this repo, @chenqingspring, has barely done anything on any of their repos in the last year: https://github.com/chenqingspring

I've been looking through all the repo forks but it's hard to find one that is maintained.

@lazysergey
Copy link

lazysergey commented Nov 27, 2019

@thomazcapra @fake230 @graemeblackwood we forked this, added typescript and rewrote some parts so now it fits current lottie-web typings/naming. see https://github.com/crello/react-lottie

@mifi
Copy link

mifi commented Jul 12, 2020

I never got any of the existing lottie-web React wrappers to correctly react to changes in props and properly play segments. So I made a complete rewrite using modern hooks only: react-lottie-player. No more deprecation warnings!

@tavareshenrique
Copy link

@lazysergey Thanks for that, bro, it works for me!

@Girish3002
Copy link

Girish3002 commented Jan 31, 2023

@lazysergey Thanks , now works fine for me

@ngoctan3006
Copy link

@lazysergey It not working for me ☹️

Warning: Using UNSAFE_componentWillUpdate in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.
* Move data fetching code or side effects to componentDidUpdate.
Please update the following components: Lottie2

image

@ValentinShtankoAimtraction

Yo, issue from 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants