Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AuthSession.startAsync no longer supported in expo-auth-session #84

Open
sethi-ishmeet opened this issue Jul 8, 2023 · 4 comments

Comments

@sethi-ishmeet
Copy link

Describe the bug
I am not able to work around the OAuth Signin/signup as the startAsync method is not supported anymore by Expo AuthSession.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade Expo and expo-auth-session to latest version
  2. Sign In with any OAuth provider
  3. See error

Expected behavior
Login/Signup should work as expected.

Screenshots
Screenshot 2023-07-07 at 9 38 45 PM

Screenshot 2023-07-07 at 9 42 08 PM

Able to repro on iOS simulator and device.

@dozken
Copy link

dozken commented Jul 10, 2023

Hi @sethi-ishmeet,
I believe you've upgraded expo to v49
here is workaround to that https://blog.expo.dev/expo-sdk-49-c6d398cdf740#:~:text=AuthSession%20proxy%20has,%2C%20Google.

@sethi-ishmeet
Copy link
Author

@dozken does that mean we cannot use this method of Authentication? When using clerk, would you recommend using their sign in components directly on the Expo side? I guess I wouldn't wanna do that because it will defeat the purpose of having the monorepo at the first place.

PS - please excuse me for naive questions as I'm transitioning to RN from native iOS development and not very familiar with patterns used here.

@dozken
Copy link

dozken commented Jul 11, 2023

@dozken does that mean we cannot use this method of Authentication? When using clerk, would you recommend using their sign in components directly on the Expo side? I guess I wouldn't want to do that because it would defeat the purpose of having the monorepo in the first place.

I'm not RN expert either but I believe you could do as they described here https://clerk.com/docs/quickstarts/get-started-with-expo in the ui module, not touching the expo module directly.

I think the intention of this repository was to give some experience on how to build a single component for both Frontend App and Mobile App, but not a guide on how to do authentication.

I suggest not updating any dependency in this library if you are new to RN until you are confident to do so. Because it works out of the box, at least on localhost.

@sethi-ishmeet
Copy link
Author

sethi-ishmeet commented Jul 11, 2023

@dozken I see, I actually used the Tamagui starter and added the Clerk Auth on top from this repo. A better idea would be to use this repo as a starter in my case I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants