Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: CI doesn't complain when notebooks fail #798

Open
KnathanM opened this issue Apr 16, 2024 · 0 comments · May be fixed by #840
Open

[BUG]: CI doesn't complain when notebooks fail #798

KnathanM opened this issue Apr 16, 2024 · 0 comments · May be fixed by #840
Labels
bug Something isn't working
Milestone
v2.0.1

Comments

@KnathanM
Copy link
Contributor

Describe the bug
Here in our CI we run the example notebooks to make sure they still run without errors. In #737 I accidently left a merge artifact in training.ipynb. The CI shows that the notebook wouldn't run and that other notebooks (training_regression_multicomponent.ipyn) also had errors. Why did the CI report all checks passed when they didn't?
@KnathanM KnathanM added the bug Something isn't working label Apr 16, 2024
@kevingreenman kevingreenman modified the milestones: v2.1.0, v2.0.1 Apr 16, 2024
@hwpang hwpang linked a pull request Apr 24, 2024 that will close this issue
Open
2 tasks
@hwpang hwpang linked a pull request Apr 24, 2024 that will close this issue
V2: Add all notebooks to test #840
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging a pull request may close this issue.

V2: Add all notebooks to test hwpang/chemprop
2 participants
@kevingreenman @KnathanM