Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Move --ignore-columns to common args #793

Open
KnathanM opened this issue Apr 13, 2024 · 0 comments
Open

[FEATURE]: Move --ignore-columns to common args #793

KnathanM opened this issue Apr 13, 2024 · 0 comments
Labels
enhancement a new feature request
Milestone

Comments

@KnathanM
Copy link
Contributor

For the sampl benchmark, the test sets have more columns than just the smiles. I believe currently chemprop predict only works if you only have smiles to predict on in your test set. It isn't too hard to delete the extra columns, but we can also just easily move --ignore-columns to common.py and then chemprop predict will recognize that.

@KnathanM KnathanM added the enhancement a new feature request label Apr 13, 2024
@kevingreenman kevingreenman added this to the v2.1.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature request
Projects
None yet
Development

No branches or pull requests

2 participants