Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization using RDKit does not converge for very long segment of proteins #69

Open
josevlibera2010 opened this issue Jul 22, 2022 · 3 comments

Comments

@josevlibera2010
Copy link

josevlibera2010 commented Jul 22, 2022

I have been trying to compute protein-protein ifps between a protein with more than 1000 AAs and a small peptide of 6 AAs. To accomplish this task, I had to manually increase the maximum number of iterations in the function "_rebuild_conjugated_bonds" at "MDAnalysis/converters/RDKit.py" and split the analysis into three, separating the protein into three pieces.

@cbouy
Copy link
Member

cbouy commented Aug 12, 2022

Hi,

This sounds more like an issue with the RDKitConverter from MDAnalysis, so I suggest that you open an issue with them for this.

Best,
Cédric

@richardjgowers
Copy link

@cbouy not an issue for here, but for the RDKit converter, we could probably hard code the standard AAs and not use your heuristics for guessing bond orders.

This is what I currently do for loading PDB files w/ bond orders:
https://github.com/OpenFreeEnergy/pdbinf/blob/main/src/pdbinf/_pdbinf.py#L114

Where the templates are:
https://github.com/OpenFreeEnergy/pdbinf/blob/main/src/pdbinf/_standard_AAs.py

So could either have this as a dep, or move the hardcoded cif files over and rewrite the logic to avoid the rdkit dependency (though MDA will probably not mind including rdkit more often..)

@cbouy
Copy link
Member

cbouy commented Oct 11, 2023

@richardjgowers I started reorganizing the converter code to make it more modulable during the UGM hackathon, i.e. you'd have the possibility to provide your own callable to infer bond orders on a mol, so wrapping up a pdbinf-based callable could definitely be an option if I manage to make some time to finish the PR some day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants