Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Chef 12.5 custom resources #235

Closed
wants to merge 2 commits into from
Closed

Update to Chef 12.5 custom resources #235

wants to merge 2 commits into from

Conversation

detjensrobert
Copy link
Contributor

@detjensrobert detjensrobert commented Jul 30, 2021

Signed-off-by: Robert Detjens detjensrobert@osuosl.org

Description

Instead of using Chef 11 resource/providers, switch to Chef 12 custom resources. This also enables unified_mode for Chef 17 compatibility.

Issues Resolved

Fixes #217.

Check List

Signed-off-by: Robert Detjens <detjensrobert@osuosl.org>
.rubocop.yml Outdated Show resolved Hide resolved
attributes/default.rb Outdated Show resolved Hide resolved
libraries/matchers.rb Outdated Show resolved Hide resolved
metadata.rb Outdated Show resolved Hide resolved
resources/default.rb Outdated Show resolved Hide resolved
resources/default.rb Outdated Show resolved Hide resolved
resources/default.rb Outdated Show resolved Hide resolved
resources/default.rb Outdated Show resolved Hide resolved
Signed-off-by: Robert Detjens <detjensrobert@osuosl.org>
@tas50
Copy link
Contributor

tas50 commented Sep 21, 2021

Sadly I'm going to have to close this out. We have a large number of folks trying to use this today to migrate off pre-12.5 releases. It's sad, but the reality we have.

@tas50 tas50 closed this Sep 21, 2021
@jeffbyrnes
Copy link

@tas50 wouldn't those folks be able to stick with an older version of this cookbook to do those migrations?

@detjensrobert
Copy link
Contributor Author

What's the plan for unified_mode Chef 17/18 compatibility with this cookbook if this PR is closed? Does unified_mode work with the legacy LWRPs?

@tas50
Copy link
Contributor

tas50 commented Sep 28, 2021

@detjensrobert We can make it work only on systems with unified mode.

@jeffbyrnes
Copy link

@tas50 wouldn’t folks be able to pin to a version that works w/ Chef < 12.5 to use it to migrate? Or am I missing something?

@tas50
Copy link
Contributor

tas50 commented Oct 6, 2021

@jeffbyrnes We're trying to build a single cookbook for all releases and pre-12.9 (when custom resources really worked reliably) is a pretty common upgrade path for customers. This cookbook maintains compatibility all the way back to 11.x for that reason.

@jeffbyrnes
Copy link

Ok, makes sense! Thanks.

@lamont-granquist
Copy link
Contributor

unified_mode false if defined?(:unified_mode) is probably the way to solve this

@detjensrobert detjensrobert mentioned this pull request Oct 8, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Chef Infra Client 12.5+
4 participants