Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on Node12 #133

Open
ISNIT0 opened this issue Jul 1, 2019 · 9 comments
Open

Release on Node12 #133

ISNIT0 opened this issue Jul 1, 2019 · 9 comments

Comments

@ISNIT0
Copy link
Collaborator

ISNIT0 commented Jul 1, 2019

MWOffliner would love to have a node 12 release (openzim/mwoffliner#707)

This merged pr: #130 gets node 12 support working, but I think we still need to update the emscripten code.

@kelson42
Copy link

@jjrv Any timeline here? It is slowly becoming a problem to not support nodejs12 for software relying on nbind.

@mceIdo
Copy link

mceIdo commented Dec 12, 2019

If anyone is interested, we've published a fork:
@mcesystems/nbind
(https://www.npmjs.com/package/@mcesystems/nbind)

We needed it for node 12 migration, so we just forked the module as is (plus a minor TS fix) and changed the name - works great.
@jjrv if you ever release here, please notify on this issue so we can deprecate our published module and revert to this one.

The fork: https://github.com/mceSystems/nbind

@kelson42
Copy link

@mceIdo Thank you very much

@kelson42
Copy link

@jjrv Also, if you have abandoned the maintenance of this repo. this would be really benefit to have a notice.

@nilres
Copy link

nilres commented Jan 14, 2020

@jjrv I would also be very interested if there is any maintenance/development ongoing.

@kelson42
Copy link

@mceldo We still don't have checked with your fork
@nilres @mceldo I guess the project is abandonned. What would be a maintained alternative to nbind?

@mceIdo
Copy link

mceIdo commented Feb 29, 2020

@kelson42, to be honest, given the awesome work done on N-API and the complementary node-addon-api for c++, next time I'll develop a new native module, or have a major refractor in one of my existing ones - I'll probably move to N-API based implementation

@nilres
Copy link

nilres commented Mar 1, 2020

I was forced to go with embind directly. And work around the deficiencies it has.
What nbind was offering was a great addition but as it seems to be an abondon project I rather go with something that is activly maintained.

@Skywalker13
Copy link

Skywalker13 commented Apr 17, 2020

If anyone is interested, we've published a fork:
@mcesystems/nbind
(https://www.npmjs.com/package/@mcesystems/nbind)

We needed it for node 12 migration, so we just forked the module as is (plus a minor TS fix) and changed the name - works great.
@jjrv if you ever release here, please notify on this issue so we can deprecate our published module and revert to this one.

The fork: https://github.com/mceSystems/nbind

It's broken with node >= v13 or electron >= 8 which use (node v12 but) a newer version of v8 (like node v13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants