Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepCurveTool #88

Open
falkhofmann opened this issue Jan 10, 2022 · 1 comment
Open

Add DeepCurveTool #88

falkhofmann opened this issue Jan 10, 2022 · 1 comment
Assignees

Comments

@falkhofmann
Copy link
Collaborator

during some research, i came across this repo with a curvetool variant for deeps.

i have reached out to matt but havent heard back from him. just asked if we could use his code as base.

otherwise we could start our own. but i like the diea to mimic the 2d curvetool. in addition it could be resulting more like sample amount (min/max) etc.

@falkhofmann falkhofmann self-assigned this Jan 16, 2022
@falkhofmann
Copy link
Collaborator Author

hey guys, i am stuck with this very one. for some reason i cant get the deepPlane to work withing the execute method.

the same logic works in the doDeepEngine method on other nodes.

does someone has an idea on how to proceed?

void DeepCCurveTool::execute()
{
    DeepPlane inPlane;

    ChannelSet needed = _channels;  // _channels is channel mask knob
    needed += Mask_Deep;
    Box box(_roi[0], _roi[1], _roi[2], _roi[3]);  // user defined ROI

    if (!input0()->deepEngine(box, needed, inPlane))
    {  // fails here to initialise the DeepPlane
        std::cout << "cancel upfront" << std::endl;
        std::cout << "box: " << box.x() << " " << box.y() << " " << box.r() << " " << box.t() << " " << std::endl;
        std::cout << "channels  " << _channels << std::endl;
        std::cout << "inPlane box: " << inPlane.box().x() << " " << inPlane.box().y() << " " << inPlane.box().r() << " " << inPlane.box().t() << " " << std::endl;
        std::cout << "inPlane channels: " << inPlane.channels() << std::endl;
        return;
    }

output:
cancel upfront
box: 36 44 794 570
channels rgb
inPlane box: 0 0 1 1
inPlane channels: none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant