Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot apply patches to new Drupal 10 installation #650

Open
laurencefass opened this issue Jan 9, 2024 · 3 comments
Open

cannot apply patches to new Drupal 10 installation #650

laurencefass opened this issue Jan 9, 2024 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@laurencefass
Copy link

Package containing the bug

I’m not sure

Describe the bug

Im following the instructions for applying patches, and they are not working with Drupal 10.

added these to composer.json

        "patches": {
            "drupal/subrequests": {
                "Get same results on different request": "https://www.drupal.org/files/issues/2019-07-18/change_request_type-63049395-09.patch"
            },
            "drupal/decoupled_router": {
                "Unable to resolve path on node in other language than default": "https://www.drupal.org/files/issues/2022-11-30/decouple_router-3111456-resolve-language-issue-58.patch"
            }
        },

On the command line:

bash-5.1# composer require cweagans/composer-patches
Using version ^1.7 for cweagans/composer-patches
./composer.json has been updated
Running composer update cweagans/composer-patches
Gathering patches for root package.
Removing package drupal/decoupled_router so that it can be re-installed and re-patched.
  - Removing drupal/decoupled_router (2.0.4)
Removing package drupal/subrequests so that it can be re-installed and re-patched.
  - Removing drupal/subrequests (3.0.10)
Deleting /var/www/html/web/modules/contrib/decoupled_router - deleted
Deleting /var/www/html/web/modules/contrib/subrequests - deleted
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/subrequests (3.0.10): Extracting archive
  - Installing drupal/decoupled_router (2.0.4): Extracting archive
  - Applying patches for drupal/subrequests
    https://www.drupal.org/files/issues/2019-07-18/change_request_type-63049395-09.patch (Get same results on different request)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-07-18/change_request_type-63049395-09.patch

  - Applying patches for drupal/decoupled_router
    https://www.drupal.org/files/issues/2022-11-30/decouple_router-3111456-resolve-language-issue-58.patch (Unable to resolve path on node in other language than default)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2022-11-30/decouple_router-3111456-resolve-language-issue-58.patch

Generating autoload files
53 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
bash-5.1# 

Please let me know if can provide any further information.

@laurencefass laurencefass added bug Something isn't working triage A new issue that needs triage labels Jan 9, 2024
@yobottehg
Copy link
Contributor

Patch for subrequests is no longer required as this has been commited and released in 3.0.10:
https://www.drupal.org/project/subrequests/issues/3049395

@laurencefass
Copy link
Author

thanks for feedback, and great to know that the project is still active!

@JohnAlbin JohnAlbin added documentation Improvements or additions to documentation and removed triage A new issue that needs triage labels Feb 20, 2024
@JohnAlbin JohnAlbin added this to the next-drupal 2.0.0 milestone Feb 20, 2024
@JohnAlbin
Copy link
Collaborator

The docs need to be updated to reflect that the patch is no longer needed.

@JohnAlbin JohnAlbin reopened this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants