feat(next): dynamic consumer paths #623
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides dynamic consumer paths from generated URL using Consumer collection route. fixes chapter-three#615
|
@mglaman is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
Ateee89
approved these changes
Dec 8, 2023
|
I just noticed the failures, will fix |
|
Merged in |
|
Test needs consumers added to dependencies |
|
From the error log: |
|
Ah, need to add to require-dev, which the current workflow may not do. I'll update to ensure the dependency is available during tests |
adds consumers to require dev
mglaman
commented
Feb 28, 2024
There was a problem hiding this comment.
This still isn't right. It'll break at runtime without Conumers as a true dependency.
It should check if the module exists, then do
$variables += [
'authentication_bearer' => '# Authentication',
'DRUPAL_CLIENT_ID' => 'Retrieve this from ' . $path,
'DRUPAL_CLIENT_SECRET' => 'Retrieve this from ' . $path,
];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides dynamic consumer paths from generated URL using Consumer
collection route.
fixes #615
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #615
Please add a link to the GitHub issue
where this problem is discussed.
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
Uses the collection route name and generates the relative URL.