Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amounts in configuration file #5

Open
nomaster opened this issue Oct 12, 2012 · 8 comments
Open

Amounts in configuration file #5

nomaster opened this issue Oct 12, 2012 · 8 comments

Comments

@nomaster
Copy link
Member

The amounts for deposit and payment should be configured in a file

@YtvwlD
Copy link
Member

YtvwlD commented May 31, 2016

Is this still relevant?

@YtvwlD
Copy link
Member

YtvwlD commented Jun 2, 2016

How would this be useful?

@nomaster
Copy link
Member Author

nomaster commented Jun 5, 2016

I thought it would be nice to have the currency and variety of paper money to be configurable. Maybe it's better to make them managable in the web interface as well.

@YtvwlD
Copy link
Member

YtvwlD commented Sep 20, 2017

So, how would we want to make this configurable? I don't really see this being useful in the web interface. A simple config file perhaps like this could be used:

currency:
  name: euro
  symbol: 
amounts:
  - amount: 2
    image: <path>
  - amount: 5
    image: <path>
[…]

Do we need more things configurable?

@YtvwlD YtvwlD reopened this Sep 20, 2017
@YtvwlD
Copy link
Member

YtvwlD commented Sep 20, 2017

Another thing: Do we want to expose this via the API? The API doesn't know anything about amounts, currently.
This is currently solely managed by the clients (and seperately, in each).
Edit: The upcoming Space-Market API v3 seems to have this.

@mikafinja
Copy link

I'll implement an endpoint in v3 to configure the valid amounts of deposits, etc. The images for the can be linked via the already existing endpoint for image handling.

@YtvwlD
Copy link
Member

YtvwlD commented Oct 1, 2017

Do we really want this to be user-configurable?
I'm perfectly fine with having those endpoints, but I think they should be read-only.

@mikafinja
Copy link

mikafinja commented Oct 1, 2017

We can implement this via the general informations, the server gives at the /info/ endpoint. Or an endpoint which is write-protected via a secret to be set in the config file of the server implementation. In general I would prefere to to configure it via the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants