Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure index public key file name ends with .rsa.pub #1003

Open
bgermann opened this issue Feb 8, 2024 · 2 comments
Open

Make sure index public key file name ends with .rsa.pub #1003

bgermann opened this issue Feb 8, 2024 · 2 comments

Comments

@bgermann
Copy link

bgermann commented Feb 8, 2024

When melange build --signing-key key.rsa is called, it should make sure that the index's public key name ends with .rsa.pub.
With the current implementation, if the file argument does not end with .rsa, it will still successfully generate an APKINDEX.tar.gz that does not have the correct name. Also, melange keygen should probably make sure that the key file names end with .rsa and .rsa.pub so that you do not run into issues further on.

@bgermann
Copy link
Author

When I tried building a package with the Adélie Linux repository, this problem also hits because the pubkey in their APKINDEX.tar.gz does not end on .rsa.pub but on .org.pub

@tuananh
Copy link
Contributor

tuananh commented Apr 5, 2024

someone already submitted a PR to fix this: chainguard-dev/go-apk#226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants