Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for args upon initialization of Xvfb instance #40

Open
leej3 opened this issue Aug 28, 2020 · 1 comment
Open

support for args upon initialization of Xvfb instance #40

leej3 opened this issue Aug 28, 2020 · 1 comment

Comments

@leej3
Copy link

leej3 commented Aug 28, 2020

Hi, thanks for the great tool.

I am wondering if you are willing to support extra arguments. To the wrapper upon initialization.

My use case is to pass arguments that are not a key value pair following the pattern '-'. Specifically I would do:

with Xvfb("+iglx") as xvfb:
    run_x_command_requiring_glx_extension()

Not a big deal. Currently I can resort to:

xvfb = Xvfb()
xvfb.extra_xvfb_args += ['+iglx']
xvfb.start()
run_x_command_requiring_glx_extension()
xvfb.stop()

It might be nice though. Or more generally making it more explicit in the documentation how one can deal with adding arguments that do not follow the pattern "Xvfb -key value"

EDIT: I see this is along the lines of #13. Apologies, I checked issues but not pull requests

@leej3
Copy link
Author

leej3 commented Aug 28, 2020

@ranasats this pattern solves your issue. You can't use the context manager as is to do what you want though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant