Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the start() method to do polling instead of a fixed sleep. #30

Open
cgoldberg opened this issue Nov 8, 2017 · 0 comments · May be fixed by #45
Open

Update the start() method to do polling instead of a fixed sleep. #30

cgoldberg opened this issue Nov 8, 2017 · 0 comments · May be fixed by #45

Comments

@cgoldberg
Copy link
Owner

this code is from the start() method in xvfbwrapper.py:

# give Xvfb time to start
time.sleep(self.__class__.SLEEP_TIME_BEFORE_START)
ret_code = self.proc.poll()

It uses a fixed time.sleep(.1) to wait for Xvfb startup. Change this so it calls proc.poll() in a loop with a timeout.
@cgoldberg cgoldberg mentioned this issue Oct 6, 2018
Open
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this issue Jan 11, 2019
@worldofpeace
pythonPackages.xvfbwrapper: disable tests
9257887 
See: cgoldberg/xvfbwrapper#30
dotlambda added a commit to NixOS/nixpkgs that referenced this issue Jan 11, 2019
@dotlambda
pythonPackages.nipype: 1.1.5 -> 1.1.7 (#53254)
e9b34b1 
* pythonPackages.nipype: 1.1.5 -> 1.1.7

Fix build by dropping a patch for an issue that is already fixed.
See: nipy/nipype#2701

Also had to disable tests.
See: nipy/nipype#2839

* pythonPackages.xvfbwrapper: disable tests

See: cgoldberg/xvfbwrapper#30
@mbway mbway linked a pull request May 14, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed race condition mbway/xvfbwrapper
1 participant
@cgoldberg