Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the status of noexcept? #312

Open
Tyyppi77 opened this issue May 5, 2020 · 1 comment
Open

What's the status of noexcept? #312

Tyyppi77 opened this issue May 5, 2020 · 1 comment

Comments

@Tyyppi77
Copy link

Tyyppi77 commented May 5, 2020

Hi there, thanks for the awesome library!
Are there any plans to support noexcept for the public bindings provided by the library? I found that #115 mentions this but that was 4.5 years ago.

Personally I find this the only downside of the library over old C-bindings, as IIRC C-headers are treated as noexcept by default, whereas here at least my Visual Studio 2019 warns about incorrect noexcept usage inside noexcept functions when Core Guideline Checks are enabled.

I understand that this might be challenging due to the existence of setAfterCallback, but I figured I'd at least ask.

@scheibel
Copy link
Member

We may add noexcept to most of the signatures. Even for cases as setAfterCallback this could be added. However, throwing or unwinding exceptions within noexcept functions seems to issue an immediate termination of the program. Thus, we want to make absolutely sure there will be no exception thrown.

scheibel added a commit that referenced this issue Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants