Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnifiedMap VTM: Remove pseudo-3D display of buildings (or make it configurable) #15723

Open
moving-bits opened this issue May 12, 2024 · 8 comments
Assignees
Labels
Feature Request A request for a new feature/function Feedback required Issue requires feedback of the author or another user
Projects

Comments

@moving-bits
Copy link
Member

Personally I find map display of buildings with UnifiedMap VTM confusing and harder to process than with old Mapsforge. I found out that there's a way to configure 2D/3D, so I propose to switch back to 2D (or make it configurable, if someone prefers 3D):

3D (currently) 2D (proposed)
image image

(screenshots taken with OpenAndroMaps' Berlin map + Elevate theme)

@moving-bits moving-bits added Feature Request A request for a new feature/function Feedback required Issue requires feedback of the author or another user labels May 12, 2024
@moving-bits moving-bits self-assigned this May 12, 2024
@moving-bits moving-bits added this to To do in Unified map via automation May 12, 2024
@eddiemuc
Copy link
Contributor

I strongly prefer the 3D look of buildings. Please don't remove it completely. Making it configurable would be fine for me though.

@MagpieFourtyTwo
Copy link

Don't like the 3D effect, too, cause buildings are way harder to recognize.

Which can perhaps be solved by drawing the roofs with a darker shading (already made some attempts to achieve this, but no success yet), but taking into account that there's no real information gain plus most probably higher CPU/GPU load for rendering, I would vote for 2D only, too, although an extra setting would of course be fine, too, but if so, I would suggest to set the default to false.

@eddiemuc
Copy link
Contributor

Cruiser has such a setting:
Screenshot_2024-05-12-11-18-19-21_beed72cb86d752c6022398a83c94aee3.jpg

@MagpieFourtyTwo
Copy link

Clever wording - cause "normal" is subject to evolutionary shifting. ;)

Nevertheless, just in case: I would prefer something more concrete like "3D buildings" or perhaps even "3D effects". :)

@devemux86
Copy link

3D buildings can be rendered normally or with shadows and extra OSM tags: roof, color, material, etc.

All these are included in the Mapsforge maps. 3D buildings are declared in the VTM themes.
Mapsforge themes do not declare them, so there is an extra rule in the code with default colors.

desktop
3d_shadows

@eddiemuc
Copy link
Contributor

Screenshot from c:geo VTM using a Mapsforge Offline map:
Screenshot_2024-05-12-13-08-27-62_a916ceb0c8a82619faeb76fe6b8ae997.jpg

I like it!

@bekuno
Copy link
Member

bekuno commented May 12, 2024

Screenshot from c:geo VTM using a Mapsforge Offline map: !
...
I like it!

Great!
We could integrate the configuration in the menu "Design options".

@moving-bits
Copy link
Member Author

PR #15731 adds such an option to VTM offline maps' theme options.

Additional formatting for 3D mode (as shown in screenshot above) should go into a separate PR (and maybe differentiate between 2D / 3D (as today) / 3D (extended, as shown above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A request for a new feature/function Feedback required Issue requires feedback of the author or another user
Projects
Status: To do
Unified map
  
To do
Development

No branches or pull requests

5 participants