Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact icons not working #15679

Open
SammysHP opened this issue May 1, 2024 · 3 comments
Open

Compact icons not working #15679

SammysHP opened this issue May 1, 2024 · 3 comments
Labels
Bug Issues classified as a bug Map: Unified

Comments

@SammysHP
Copy link
Member

SammysHP commented May 1, 2024

Describe your problem!

Compact icons are not working, even when forced. (unified map)

How to reproduce?

  1. Open map
  2. Enable compact icons

Actual result after these steps?

Regular large icons shown.

Expected result after these steps?

Compact icons shown.

Reproducible

Yes

c:geo Version

2024.05.01-NB-458499f

System information

No response

Additional Information

No response

@SammysHP SammysHP added Bug Issues classified as a bug Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility Map: Unified labels May 1, 2024
@SammysHP
Copy link
Member Author

SammysHP commented May 1, 2024

Apparently the setting (even automatic switching) is only applied after restarting the app.

@moving-bits
Copy link
Member

  • not reproducible for me with current release 2024.04.25 or current state of release branch
  • but reproducible with current master as of today

According to git bisect, 72c7031 seems to be the first "bad" commit, although I have no idea ad hoc, what's causing it to fail.

@SammysHP SammysHP removed the Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility label May 4, 2024
@moving-bits
Copy link
Member

This method gets triggered (correctly) on closing map quick settings after having changed compact icon mode:

private void compactIconModeChanged(final int newValue) {
    Settings.setCompactIconMode(newValue);
    viewModel.caches.notifyDataChanged(true);
}

But cache marker symbols won't update, even not after closing and reopening the map, but only after restart of c:geo.

Both UnifiedMap Google and UnifiedMap VTM are affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues classified as a bug Map: Unified
Projects
None yet
Development

No branches or pull requests

2 participants