Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check input_binding_to_location_mapping #9

Open
johannesugb opened this issue Aug 7, 2020 · 0 comments
Open

Double check input_binding_to_location_mapping #9

johannesugb opened this issue Aug 7, 2020 · 0 comments

Comments

@johannesugb
Copy link
Member

johannesugb commented Aug 7, 2020

Something seems to be confusing about

	struct input_binding_to_location_mapping
	{
		vertex_input_buffer_binding mGeneralData;
		buffer_element_member_meta mMemberMetaData;
	};

Why are the parameters stride on the one hand, and offset and format on the other hand distributed to different structs?

But maybe it's okay, because that distribution is also present when compiling the configuration for the graphics pipeline in graphics_pipeline root::create_graphics_pipeline => steps 1 and 2, when the vk::VertexInputBindingDescription and vk::VertexInputAttributeDescription elements are compiled.

Everything is working, so probably it's okay.
But just double check everything once again; especially if the data structures in input_binding_to_location_mapping are okay as they are or if they could maybe be optimized somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant