Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base conditional compilation on Vulkan SDK version for things that were added to the standard with SDK 1.2 #35

Open
1 task
johannesugb opened this issue Nov 16, 2020 · 0 comments
Open
1 task

Base conditional compilation on Vulkan SDK version for things that were added to the standard with SDK 1.2 #35

johannesugb opened this issue Nov 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@johannesugb
Copy link
Member

Instead of evaluating the header version, i.e. e.g.

#if VK_HEADER_VERSION >= 135

the following would be more appropriate for such cases:

#if defined(VK_VERSION_1_2)

Definition of done:

  • Each feature that is enabled in #if VK_HEADER_VERSION-fashion has been investigated if it is a feature that has been added to the standard with SDK version 1.2. If so, it has been replaced with #if defined(VK_VERSION_1_2).
@johannesugb johannesugb added the enhancement New feature or request label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannesugb