Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check buffer_view and buffer_view_descriptor bindings #13

Open
johannesugb opened this issue Aug 14, 2020 · 0 comments
Open

Double check buffer_view and buffer_view_descriptor bindings #13

johannesugb opened this issue Aug 14, 2020 · 0 comments

Comments

@johannesugb
Copy link
Member

johannesugb commented Aug 14, 2020

There has been some refactoring w.r.t. the binding of buffer_views:

  • class buffer_view_descriptor was introduced
  • as_uniform_texel_buffer and as_storage_texel_buffer has been removed from buffer
  • as_uniform_texel_buffer_view and as_storage_texel_buffer_view have been added to buffer_view
  • as_uniform_texel_buffer_views and as_storage_texel_buffer_views have been adapted accordingly, and so has been struct binding_data and all associated functions/methods.

It is a bit unclear if the structure is flawless/faultless.

Double check the actual descriptor infos that are written, where the data is stored, how the data is gathered, and if the vk::BufferView bindings are created properly.

This can best be investigated in the "ray_tracing_triangle_meshes" examples, because it uses buffer_views. See if everything still works, then bind explicitly using as_uniform_texel_buffer_views and also try to bind as_storage_texel_buffer_views (that will need some adaption in shaders).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant