Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching #215

Open
adprocas opened this issue Apr 25, 2017 · 4 comments
Open

Caching #215

adprocas opened this issue Apr 25, 2017 · 4 comments

Comments

@adprocas
Copy link

Hello,

I was wondering if you could explain caching for your extension. On your home page you mention caching, but what exactly is cached, and how is it cached? Is the cache supposed to persist and be used when and if a source is not available? For example, if github is down, does the library cache properties and use the most recently obtained properties?

I took a quick look at the source code, but other than having properties as a member variable in the ConfigurationSource, I don't see where caching is available. I'm kind of looking at the git implementation for this. I have extended this to work with another key-value pair system, but fail to see where caching is happening.

I will be implementing my own caching if there isn't support for caching within this extension, but I wanted to check here first.

@adprocas
Copy link
Author

adprocas commented Apr 25, 2017

After looking through the code on here I see CachedConfigurationSource. I do not have that in my library. I'm using Ivy and have cfg4j-core-4.4.0.jar, but no CachedConfigurationSource.

Any ideas?

@fabriziocucci
Copy link

@adprocas it seems that that class is not in the released version but only on the master.

@adprocas
Copy link
Author

Ah, thanks @fabriziocucci. I wonder why it isn't in the released version.

@fabriziocucci
Copy link

fabriziocucci commented Apr 25, 2017

@adprocas I guess the maintainer is quite busy lately! If you really need something that has not been released yet you may need to fork the project and release it yourself on your artifact repository...

I personally have created a spin-off project inspired by this one with a slightly more fluent API and a couple of feature I needed (but not even close in terms of completeness to this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants