Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

05-bootsector-functions-strings/boot_sect_print_hex.asm #267

Open
OmarHassanProgrammer opened this issue Aug 20, 2023 · 0 comments
Open

05-bootsector-functions-strings/boot_sect_print_hex.asm #267

OmarHassanProgrammer opened this issue Aug 20, 2023 · 0 comments

Comments

@OmarHassanProgrammer
Copy link

in line 30 shouldn't it be
ror dx, 1 instead of ror dx, 4
so we shift the 3rd letter of dx to be the last so we can convert it into ASCII (I didn't try the code I just thought about that while reading it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OmarHassanProgrammer