Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with updated constraints #101

Open
bmw opened this issue Jun 10, 2021 · 0 comments
Open

Fix tests with updated constraints #101

bmw opened this issue Jun 10, 2021 · 0 comments
Labels
priority: significant Issues with higher than average priority that do not need to be in the current milestone.

Comments

@bmw
Copy link
Member

bmw commented Jun 10, 2021

When updating constraints.txt, importlib-metadata and mypy currently need to be pinned back for tests to continue to pass. I think this should ideally be fixed.

Also, importlib-metadata is only required by flake8 in Python < 3.8 so if you install josepy with pip using Python 3.8+, this package (and its dependency zipp) won't be included in the pip freeze output. I personally think it may be worth switching this repo to use something like poetry which better handles these cases. I think we could have a more traditional poetry setup here than what we current do in the Certbot repo. This is a larger project though.

@bmw bmw added the priority: significant Issues with higher than average priority that do not need to be in the current milestone. label Jun 10, 2021
@bmw bmw mentioned this issue Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: significant Issues with higher than average priority that do not need to be in the current milestone.
Projects
None yet
Development

No branches or pull requests

1 participant