Graphic pack parser incorrectly parses commas in strings

[splatoon1enjoyer]

Current Behavior

In graphic pack patches, when defining a string:

.string "Foo ,"

Cemu's parser fails to accept commas as part of the string, which causes this error at runtime:

[20:09:22.680] Line X: Error in assembler: String constants must end with a quotation mark. Example: "text"

This is a problem when writing patches for games such as Splatoon, which have enums hard coded as string literals that get parsed at runtime, requiring the user to use commas as part of the string.

Expected Behavior

The string should be sanitized properly and consider the comma or any other reasonable character as part of the string.

Steps to Reproduce

Define a string with a comma.

System Info (Optional)

No response

Emulation Settings (Optional)

No response

Logs (Optional)

No response

[goeiecool9999]

I've looked at the code.
From the perspective of cemu's PPC assember it looks like it's a data directive with two arguments: "Foo and ". "Foo doesn't end in a " so it treats it as invalid.

Cemu/src/Cemu/PPCAssembler/ppcAssembler.cpp

Lines 2419 to 2470 in cf41c3b

	// parse operands
	internalInfo.listOperandStr.clear();
	while (currentPtr < endPtr)
	{
	currentPtr++;
	startPtr = currentPtr;
	// find end of operand
	while (currentPtr < endPtr)
	{
	if (*currentPtr == ',')
	break;
	currentPtr++;
	}
	// trim whitespaces at the beginning and end
	const char* operandStartPtr = startPtr;
	const char* operandEndPtr = currentPtr;
	while (operandStartPtr < endPtr)
	{
	if (*operandStartPtr != ' ' && *operandStartPtr != '\t')
	break;
	operandStartPtr++;
	}
	while (operandEndPtr > operandStartPtr)
	{
	if (operandEndPtr[-1] != ' ' && operandEndPtr[-1] != '\t')
	break;
	operandEndPtr--;
	}
	internalInfo.listOperandStr.emplace_back(operandStartPtr, operandEndPtr);
	}
	// check for data directives
	ASM_DATA_DIRECTIVE dataDirective = ASM_DATA_DIRECTIVE::NONE;
	if (instructionName.compare(".FLOAT") == 0)
	dataDirective = ASM_DATA_DIRECTIVE::FLOAT;
	else if (instructionName.compare(".DOUBLE") == 0)
	dataDirective = ASM_DATA_DIRECTIVE::DOUBLE;
	else if (instructionName.compare(".INT") == 0 || instructionName.compare(".UINT") == 0 || instructionName.compare(".PTR") == 0 || instructionName.compare(".U32") == 0 || instructionName.compare(".LONG") == 0)
	dataDirective = ASM_DATA_DIRECTIVE::U32;
	else if (instructionName.compare(".WORD") == 0 || instructionName.compare(".U16") == 0 || instructionName.compare(".SHORT") == 0)
	dataDirective = ASM_DATA_DIRECTIVE::U16;
	else if (instructionName.compare(".BYTE") == 0 || instructionName.compare(".STRING") == 0 || instructionName.compare(".U8") == 0 || instructionName.compare(".CHAR") == 0)
	dataDirective = ASM_DATA_DIRECTIVE::U8;
	if (dataDirective != ASM_DATA_DIRECTIVE::NONE)
	{
	if (internalInfo.listOperandStr.size() < 1)
	{
	ppcAssembler_setError(ctx, fmt::format("Value expected after data directive {}", instructionName.c_str()));
	return false;
	}
	return _ppcAssembler_emitDataDirective(internalInfo, dataDirective);
	}