Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with verification #75

Open
jon-chuang opened this issue Mar 2, 2021 · 0 comments
Open

Problem with verification #75

jon-chuang opened this issue Mar 2, 2021 · 0 comments

Comments

@jon-chuang
Copy link

jon-chuang commented Mar 2, 2021

Since we care about overlap of check_power_ratios, the correct thing to do ought actually to be to read the buffer from start to min(end+1, powers_length), not from start to end, resulting in non-overlapping checks, which is obviously wrong...

Edit: well, iter_chunk seems to handle overlap, but why is overlap correct even for ::computation.rs? Also, I don't understand why this way of handling overlap is correct...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant