Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: implement portals #916

Open
firefoxlover opened this issue Dec 30, 2023 · 7 comments
Open

FR: implement portals #916

firefoxlover opened this issue Dec 30, 2023 · 7 comments

Comments

@firefoxlover
Copy link

Celluloid is literally the only Wayland Video Player and thats great! thank you!

would be cool to have file-Portal support too, to have it fully secure and modern

@gnome-mpv
Copy link
Collaborator

We're already using GtkFileChooserNative, which will automatically use file portals if they're available.

@firefoxlover
Copy link
Author

Hm weird, on KDE I am not sure if it is a Portal. Do Desktops only have their native Portal or also another one possible?

I am pretty sure it only has the KDE portal.

@gnome-mpv
Copy link
Collaborator

You may have to install the portal separately if you haven't already done so. On some (most?) distros, installing the desktop doesn't automatically install the portal.

Do Desktops only have their native Portal or also another one possible?

From my understanding, it should be possible to install portals other than the one that's made for your desktop, although they may not integrate as well.

@firefoxlover
Copy link
Author

So then its an issue with the App. I am on Fedora Kinoite, did not install some KDE stuff on a barebones Distro.

It integrates the KDE xdg-desktop-portal and not the GNOME one, and normally for example in Firefox that works

@soumyaDghosh
Copy link

soumyaDghosh commented Jan 20, 2024

@gnome-mpv As a suggestion I think You should move to the new GtkFileDialog, there are many known bugs that GtkFileChooserNative doesn't work with portals properly. The snap package also faces the same issue. I requested the packager to enforce GDK_DEBUG=portals, but he denied it pointing out that it doesn't work on old portals from Ubuntu 22.04. I think, this migration might help to fix these portal related issues. There are several posts about it

https://forum.snapcraft.io/t/doesnt-use-the-xdg-desktop-portal/34360

https://forum.snapcraft.io/t/request-to-autoconnect-removable-media-for-gnome-text-editor/37485

The same problem was with gnome-text-editor, got fixed by GtkFileDialog.

@gnome-mpv
Copy link
Collaborator

@soumyaDghosh I have been working on GtkFileDialog migration but ran into problems with dark themes. For some reason, GtkFileDialog doesn't respect per-application dark theme settings, although it respects global dark theme just fine. This is problematic for us because we use dark theme by default; a lot of users would end up seeing light-themed file dialog even though the main window is dark-themed, which doesn't look great.

@soumyaDghosh
Copy link

Thanks for your input @gnome-mpv, hope it can be fixed asap...but, the UI theme issue can be undermined. There is this video-player clapper, it also has this same kind of situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants