Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium Site Isolation - Legacy Binding Test failure #3867

Open
amaitland opened this issue Nov 2, 2021 · 3 comments
Open

Chromium Site Isolation - Legacy Binding Test failure #3867

amaitland opened this issue Nov 2, 2021 · 3 comments

Comments

@amaitland
Copy link
Member

Commit 221185b enabled site isolation by default for master

Tests are passing with the exception of IntegrationTestFacts.LoadLegacyJavaScriptBindingQunitTestsSuccessfulCompletion. Same test passes when I run it through Visual Studio Test Explorer. A new issue should be created and debugged at some point to determine the cause and evaluate if it's fixable or if upstream changes are required.

Originally posted by @amaitland in #2967 (comment)
@amaitland
Copy link
Member Author

We should add a legacy binding test to the Net Core implementation and reorder so the netcore tests run first. See if the problem is anyway related to the WCF implementation or if it's simply a matter of the details passed in via CefBrowser are not propagating to the render processes reliably.

@amaitland amaitland mentioned this issue Nov 2, 2021
Closed
1 task
amaitland added a commit that referenced this issue Nov 19, 2021
@amaitland
Test - Skip LoadLegacyJavaScriptBindingQunitTestsSuccessfulCompletion…
e7f1ea3 
… when run via AppVeyor

Is failing all the time now.

Issue #3867
@amaitland
Copy link
Member Author

Tests are failing consistently now when run via Appveyor.

Test will be skipped when run under AppVeyor.

@amaitland amaitland mentioned this issue Dec 31, 2021
Merged
9 tasks
amaitland added a commit that referenced this issue Jan 11, 2022
@amaitland
Test - Skip LoadJavaScriptBindingQunitTestsSuccessfulCompletion
4ee889f 
Issue #3867
@amaitland amaitland mentioned this issue Jan 11, 2022
Closed
11 tasks
@amaitland
Copy link
Member Author

Possibly related https://bitbucket.org/chromiumembedded/cef/issues/3260/support-reconnect-of-mojo-frame-channel

amaitland added a commit that referenced this issue Apr 6, 2022
@amaitland
Test - Skip LoadJavaScriptBindingQunitTestsSuccessfulCompletion
c59e515 
Issue #3867
amaitland added a commit that referenced this issue May 31, 2022
@amaitland
Test - Skip LoadJavaScriptBindingQunitTestsSuccessfulCompletion
527aab2 
Issue #3867
amaitland added a commit that referenced this issue Aug 8, 2022
@amaitland
Test - Skip LoadJavaScriptBindingQunitTestsSuccessfulCompletion
532a649 
Issue #3867
amaitland added a commit that referenced this issue Aug 9, 2022
@amaitland
Test - Skip LoadJavaScriptBindingQunitTestsSuccessfulCompletion
b94f08e 
Issue #3867
amaitland added a commit that referenced this issue Sep 8, 2022
@amaitland
Test - Renable JavascriptBinding IntegrationTestFacts
3899f32 
- Now that https://bitbucket.org/chromiumembedded/cef/issues/3260/support-reconnect-of-mojo-frame-channel has been resovled see if the
tests will run on appveyor reliable
- Use a new RequestContext to isolate the unreliable test cases.

Issue #3867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amaitland