Numerous problems with draggable rows in combination with grouping

[elineopsommer]

There are numerous problems in combination with grouping.
When you drag a row between two group headers you expect the row to be inserted at the correct position.
For example: if you drags a row below a group header, the dragged row needs to be inserted at the target group header. If you drags a row above a group header, the dragged row needs to be inserted at the group header above the target.

I created a codepen to show the problem.
codepen

I also created a PR (which is probably not fully covered, but the main problem is covered)
pull request

Thanks for looking into this.

[skrajewski]

Hi,
it seems that the example doesn't work. Could you check this?

Thanks!

[elineopsommer]

The example shows the current bugs. What doesn't work exactly?

[elineopsommer]

If you debug the code you will see it does not work correctly. When you drags a row between two group headers, the returned 'toIndex' is -1.

[elineopsommer]

Any updates on this?

[andrzejwp]

Hello @elineopsommer we will try to look into this and let you know.

[gdaszuta]

Hi @elineopsommer,
I've reformatted your submission, you can check it out on https://github.com/cdwv/ui-grid-draggable-rows/compare/hotfix/issue-54-draggable-rows-grouping?expand=1 and https://codepen.io/anon/pen/MowMBM – I'm not fully familiar with this project, but your patch looks so far good to me. Next time please try to avoid reformatting code using jsbeautifier et consortes before commiting, it makes patches ridiculously huge and difficult to review.
I have no claim to this patch, so if you wish, you can resubmit my commit as new pull request – otherwise, I'll merge my branch and close this ticket.

[elineopsommer]

@gdaszuta I guess there is a problem with the codepen? I can't move a row between two groupheaders?

[gdaszuta]

@elineopsommer I just reformatted your patch – but I see what you mean. It works – sort of. I think I see the problem – it looks like there are two drop zones separated by one pixel in bottom of row directly above group header – in the codepen one of them works, one don't. When I tested it locally, both was working on the same release. Probably I need some more time to investigate this behavior.

[elineopsommer]

@gdaszuta Thanks for looking into this!

[elineopsommer]

@gdaszuta Did you already find time to look into this?