Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out sort_and_reindex into multiple phases #82

Open
cdown opened this issue Mar 4, 2022 · 0 comments
Open

Split out sort_and_reindex into multiple phases #82

cdown opened this issue Mar 4, 2022 · 0 comments

Comments

@cdown
Copy link
Owner

cdown commented Mar 4, 2022

sort_and_reindex currently does too much. It:

  1. Sorts the subtitles
  2. Reindexes them
  3. Skips subtitles based on the rules

Each of these should ideally become its own function, and sort_and_reindex should be deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant