Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review current code base #2

Open
3 of 4 tasks
egonw opened this issue Nov 8, 2017 · 9 comments
Open
3 of 4 tasks

review current code base #2

egonw opened this issue Nov 8, 2017 · 9 comments

Comments

@egonw
Copy link
Member

egonw commented Nov 8, 2017

@sithmein, can you have a look at this too?

Checks needed:

  • is everything included to open this in Eclipse
  • does it compile
  • does it run in KNIME from within the SDK
  • does an export lead to proper installable product
@sithmein
Copy link

Can you move the projects in org.openscience to top-level? This is the standard setup for all other Git repositories and the build system expects the projects there.
I will change the build job in Jenkins to use the new Git repo and then we see whether it works or not.

@egonw egonw self-assigned this Nov 10, 2017
@egonw
Copy link
Member Author

egonw commented Nov 10, 2017

OK, yes, I can do that.

@egonw egonw removed their assignment Nov 10, 2017
@egonw
Copy link
Member Author

egonw commented Nov 10, 2017

@sithmein, done!

@sithmein
Copy link

The Jenkins job works fine, however there is a testcase failure (although not new as far as I can tell):

https://community.knime.org/jenkins/job/org.openscience.cdk.knime.update-trunk/lastCompletedBuild/testReport/

(access with your KNIME forum account, in case it doesn't work, tell me your account name).

@egonw
Copy link
Member Author

egonw commented Dec 6, 2017

@sithmein, turned out I did not have a forum account yet, but I'm now in the pending list...

@egonw
Copy link
Member Author

egonw commented Mar 11, 2018

@sithmein, does the Jenkins build service create an update site from which people can install the development version? At least, allowing me to test the last step (4)?

@sithmein
Copy link

All stable builds will be deployed to the corresponding public update sites (see https://www.knime.com/community for a full list). Unstable builds can only be downloaded from the Jenkins job.

@egonw
Copy link
Member Author

egonw commented Mar 14, 2018

OK, I guess Jenkins automatically sets versions numbers of the feature, correct? I also do not have to set the KNIME version it is for, right (with updates like this)?

@sithmein
Copy link

The .qualifier is filled automatically with the last change date in the SCM and is propagated to the featue. The first three parts of the version number you have to set manually and you are free to choose them yourself (following the rules for semantic versioning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants