Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by tag: Inconsistency of $ #8

Open
IgorEisberg opened this issue Dec 6, 2023 · 2 comments · May be fixed by #9
Open

Filter by tag: Inconsistency of $ #8

IgorEisberg opened this issue Dec 6, 2023 · 2 comments · May be fixed by #9

Comments

@IgorEisberg
Copy link

IgorEisberg commented Dec 6, 2023

Hi, thanks for the excellent log viewer.
This is a minor issue, but something annoying nonetheless.
When filtering by tag using a regex pattern, ^ always matches the beginning of the tag, but $ doesn't always match the end of it.
Example:

12-05 22:22:48.538   728  1160 I zygote  : Verified 41637 classes from mainline modules in 4.623s

Filtering by ^zygote$ correctly finds this line.
However:

12-05 22:23:37.314  1436  1753 D PackageManager: writeLegacyPermissionState for user 0 in 13 ms.

Filtering by ^PackageManager$ finds nothing.
Filtering by ^PackageManager:$ finds the line, but the : is not really part of the tag, just like it's not part of the zygote tag (filtering by ^zygote:$ or ^zygote :$ finds nothing).

Hope you can patch it up.
Thanks in any case.

@cdcsgit
Copy link
Owner

cdcsgit commented Dec 7, 2023

This occurs because the character following the tag is not a white space.
Please use ".?" temporarily.
^zygote.?$
^PackageManager.?$

I will improve it in the next version.

@IgorEisberg
Copy link
Author

IgorEisberg commented Dec 7, 2023

This occurs because the character following the tag is not a white space. Please use ".?" temporarily. ^zygote.?$ ^PackageManager.?$

I will improve it in the next version.

Understandable, considering that tags can contain : as well, makes it harder to identify a tag.
Been using \b as a workaround for now, works but not failproof (cause tags can contain characters not within \w).

^(zygote|PackageManager)\b

@IgorEisberg IgorEisberg linked a pull request Dec 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants