New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should API throw an error when aggregating on non-existing field? #34

Open

vanatteveldt opened this issue Mar 14, 2023 · 0 comments

Labels

question

Member

vanatteveldt commented Mar 14, 2023

Currently, aggregating on a field that doesn't exist throws an error:

amcat4/amcat4/elastic.py

Line 269 in c6fae87

return get_fields(index)[field_name]["type"]

Alternatively, some non-error response could be returned that would be identical to a field that is defined, but never used.

In any case it would probably be good to have a consistent response here for filtering, aggregating, selecting columns, etc.

vanatteveldt added the question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment