Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the songs in Music, not in cache #83

Open
Jak2k opened this issue Mar 15, 2024 · 3 comments
Open

Cache the songs in Music, not in cache #83

Jak2k opened this issue Mar 15, 2024 · 3 comments

Comments

@Jak2k
Copy link

Jak2k commented Mar 15, 2024

I would really love an option to save the file in ~/Music/<ALBUM>/<SONG>.mp3 instead of ~/.cache/ytermusic/downloads. This would allow me to also listen to my music with other software and should be a quite small change.

@ccgauche
Copy link
Owner

It used to be like that but there are some issues with song names (that can contains characters or names) that can't be handled by some file systems (For instance there are some reserved words names can't contain / ... which is allowed as song title on YT Music.
But an export option could be indeed useful (I've already created it to sync with my phone but didn't release it)

@Jak2k
Copy link
Author

Jak2k commented Mar 16, 2024

That forbidden-name thing should be a Windows-only thing. Maybe you could escape it somehow and embed the real title in the mp3-metadata.

@ccgauche
Copy link
Owner

That's definitely an option I just wanna ensure security so my users don't get hacked via file path tricks. I'll probably use a very strict escaping method but for the meta part I'll have to look at the performance implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants