Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to ctrl+c twice if music is playing #27

Open
Alphare opened this issue Nov 22, 2022 · 11 comments
Open

Need to ctrl+c twice if music is playing #27

Alphare opened this issue Nov 22, 2022 · 11 comments
Labels
question Further information is requested

Comments

@Alphare
Copy link

Alphare commented Nov 22, 2022

If music is playing, the ctrl+c signal does not propagate to the task playing the music, which forces the user to ctrl+c again. Same goes for ctrl+d, except the second chord still needs to be ctrl+c.

I'm assuming this is related to https://tokio.rs/tokio/topics/shutdown?

@ccgauche
Copy link
Owner

I'm using exit(0) so no issue normally.

@ccgauche
Copy link
Owner

I can't reproduce the issue on my side... @Alphare

@Alphare
Copy link
Author

Alphare commented Nov 22, 2022

Interesting. I am running on Linux, if that changes anything. I'm not sure what you would need to help reproduce.

@ccgauche
Copy link
Owner

Gonna try on my linux machine as soon as possible

@ccgauche
Copy link
Owner

@Alphare Can't reproduce it on an Ubuntu 20 based system

@ccgauche ccgauche added the question Further information is requested label Dec 12, 2022
@zopieux
Copy link

zopieux commented Feb 22, 2023

Can reproduce on an Arch machine at master.

My audio server is Pipewire.

@ccgauche
Copy link
Owner

I'll take a look tomorrow at the issue but can't reproduce it on PopOS or Fedora with gnome-shell (I'll maybe try alacrity)

@ccgauche
Copy link
Owner

@zopieux @Alphare Tell me if 2f2eebd fixed your issue

@Alphare
Copy link
Author

Alphare commented Feb 23, 2023

With 2f2eebd, I can't stop the process altogether. The UI disappears with the first, then no amount of Ctrl+C-ing will do anything.

@ccgauche
Copy link
Owner

@Alphare 372b21b should do the trick. I managed to reproduce the issue with alacritty and now it works for me

@Alphare
Copy link
Author

Alphare commented Feb 23, 2023

This is unfortunately still broken for me. I'm also using alacritty on a Debian install. Sorry I can't lend any more help right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants