Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple modifier keys will not bind to 'keyup' #316

Open
prominentdetail opened this issue Dec 10, 2015 · 3 comments
Open

Multiple modifier keys will not bind to 'keyup' #316

prominentdetail opened this issue Dec 10, 2015 · 3 comments

Comments

@prominentdetail
Copy link

For example:
mousetrap.bind('ctrl+alt', bindUp, 'keyup');
or
mousetrap.bind('shift+space', bindUp, 'keyup');
..will not fire when those are released.
Any help solving this would be appreciated, or direction towards where in the code this type of thing is handled so that I can try fixing it.

@robincafolla
Copy link

Testcase: http://jsfiddle.net/08moucLg/1/

Works for 'shift+space' but not for 'ctrl+alt'

@prominentdetail
Copy link
Author

ah.. yea I checked again and seems space works..
But any combination of ctrl,alt,shift, and meta won't trigger a keyup.

@prominentdetail
Copy link
Author

Okay, I created a pull request to show a fix I've made for this problem: #317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants