Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting device ID in disk drive regardless of item type #1699

Open
Ale32bit opened this issue Jan 26, 2024 · 3 comments
Open

Getting device ID in disk drive regardless of item type #1699

Ale32bit opened this issue Jan 26, 2024 · 3 comments
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.

Comments

@Ale32bit
Copy link
Contributor

As of now the function disk.getDiskID returns the ID of the item in the drive, but only if the item is a disk.

What this feature request suggests is returning the ID of the drive-compatible item regardless of the type (disk, computer, turtle, pocket computer).
In addition to this, to avoid ID collisions, a new function can be introduced to return the type of the item, I.E. disk.getItemType.

@Ale32bit Ale32bit added the enhancement An extension of a feature or a new feature. label Jan 26, 2024
@SquidDev SquidDev added the area-Minecraft This affects CC's Minecraft-specific content. label Jan 26, 2024
@SquidDev
Copy link
Member

Some rationale/use case for a feature. My general approach to designing new features is to ask yourself "what issue are we trying to solve" and then "is this the best way to solve this issue?".

I think it would perhaps be useful to have some additional context here. One of the struggles I have with both this issue and #634 is that I'm not sure what you're really trying to solve here - is this just for display purposes, or something else?

Personally I kinda feel getDiskID (or indeed exposing them user-side at all) was a bit of a mistake. For computers it makes sense - ids are needed for rednet - but less so for anything else.

@GStefanowich

This comment was marked as off-topic.

@SquidDev

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants