Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bayefdr #184

Closed
alanocallaghan opened this issue Jun 25, 2020 · 2 comments
Closed

Use bayefdr #184

alanocallaghan opened this issue Jun 25, 2020 · 2 comments
Projects
3.12 release

Comments

@alanocallaghan
Copy link
Collaborator

There are 2 edge cases that the package doesn't cover but otherwise should be fine to mostly just remove the code and replace with calls. Once I've changed I'll push to CRAN
@alanocallaghan alanocallaghan added this to To do in 3.12 release via automation Jun 25, 2020
@alanocallaghan alanocallaghan mentioned this issue Aug 5, 2020
Closed
@alanocallaghan
Copy link
Collaborator Author

alanocallaghan commented Sep 9, 2020 •
edited

This simplifies the Result classes since they can just store the bayefdr object instead of ProbThresholds/EFDRGrid/EFNRGrid

@alanocallaghan alanocallaghan moved this from To do to In progress in 3.12 release Sep 9, 2020
@alanocallaghan alanocallaghan moved this from In progress to To do in 3.12 release Sep 9, 2020
@alanocallaghan
Copy link
Collaborator Author

This is slightly more complex than I thought. We don't currently store the probability thresholds that we check for EFDR/EFNR (that seems very wrong to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.12 release
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanocallaghan