Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom batch size is not honoured for checker task #575

Open
golenkovm opened this issue Aug 9, 2023 · 0 comments
Open

Custom batch size is not honoured for checker task #575

golenkovm opened this issue Aug 9, 2023 · 0 comments

Comments

@golenkovm
Copy link
Contributor

golenkovm commented Aug 9, 2023 •
edited

It looks like batchsize for checker task that is defined here https://github.com/catalyst/moodle-tool_objectfs/blob/MOODLE_310_STABLE/classes/local/object_manipulator/checker.php#L44 is ignored in get() method which gets candidates for the task https://github.com/catalyst/moodle-tool_objectfs/blob/MOODLE_310_STABLE/classes/local/object_manipulator/candidates/manipulator_candidates_base.php#L61 . Instead, the current config value is used.

PS: This may not bite us anymore as #554 has been fixed, but still an issue from the coding perspective
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@golenkovm