Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a setting for signed urls to embed the ip of the user into it #539

Open
4 tasks
brendanheywood opened this issue Feb 6, 2023 · 0 comments
Open
4 tasks

Comments

@brendanheywood
Copy link
Contributor

  • Detect the users ip
  • bake that into the signed url
  • See if it is carefully cache the redirect url using a header which is hashed off the ip so that if and when the user changes ip then the redirect will be busted and you'll get a new signed url with the new ip. This may not be viable
  • The logic above can be skipped if $CFG->tracksessionip is on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant