Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max_files in vscode settings #690

Open
DoloMike opened this issue Oct 11, 2023 · 1 comment
Open

Support max_files in vscode settings #690

DoloMike opened this issue Oct 11, 2023 · 1 comment

Comments

@DoloMike
Copy link

Requesting to support max_files in vscode settings as well. I think this would be beneficial because:

  • some large projects do not use solargraph by default and thus do not have a .solargraph.yml (i.e., most contributors use an editor like Rubymine).
  • they don't want to add a .solargraph.yml to the project file OR add .solargraph.yml to the .gitignore
  • vscode settings are a common method of managing dev tool extensions configurability, as opposed to having a specific .config file for each extension

Some reactions to this answer indicate there is some agreement this should also be manageable from vscode settings (instead of only .solargraph.yml
#54 (comment)

Open question pertaining to max_files but would be applicable to any setting that is supported in both places:

  • If max_files has a value in both the project's .solargraph.yml as well as the vscode settings, which should take precedence? My assumption is that .solargraph.yml should always be given preference.
@aspirisen
Copy link

Any updates? That would be a useful feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants