Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate GUID (Delphi) #517

Open
peardox opened this issue Jul 5, 2023 · 4 comments
Open

Duplicate GUID (Delphi) #517

peardox opened this issue Jul 5, 2023 · 4 comments

Comments

@peardox
Copy link
Collaborator

peardox commented Jul 5, 2023

I'm just building an AllExamples project group and this popped up...

dupeguid

This also happened for fps_game_standalone

The project group was created by navigating to examples in Explorer then searching for *.dproj which creates an view of all trhe dproj files. These can then be all selected and simply dragged into a project after deleting the default one Delphi generates itself

145 dproj files... Wonder how long to build them all :)

@peardox
Copy link
Collaborator Author

peardox commented Jul 5, 2023

FYI

AllExamples.zip

Stick it in examples and unzip it (stupid Github don't like the groupproj ext)

@peardox
Copy link
Collaborator Author

peardox commented Jul 5, 2023

Jeez - it's building CGE 145 times from the look of it :(

There's a prefectly good CGE already installed it's completely ignoring....

@michaliskambi
Copy link
Member

Duplicate GUID is a consequence of our --guid-from-name, that we use only for examples, to have examples\regenerate_auto_files_in_all_examples.sh repeatable. So CGE examples with equal project names will indeed have colliding GUIDs.

It doesn't affect normal users, it doesn't affect normal projects (GUIDs are not deterministic based on name, normally).

In the long run, examples\deprecated_to_upgrade\isometric_game\ and examples\deprecated_to_upgrade\fps_game_old_ai\ should just be removed (both of these should happen before 7.0 release), so the problem will be solved this way. For now just ignore it.

AllExamples -- thank you, though if we decide to add it, we definitely need application to autogenerate this file. We don't want to have to maintain it each time we add new example :)

@peardox
Copy link
Collaborator Author

peardox commented Jul 5, 2023

Yeah I noticed all the deprecated ones when weeding out the bad ones too. They should really either be removed or not included in AllExamples

I wrote code to auto generate the group project file for MakeP4DComponents although admitedly it didn't use a XML library - just output the specific lines XML lib would have generated.

I have already thought of doing the same for CGE's examples. I thought that something similar to a gitignore could control a scan of dirs that looks jor dproj files and builds based on that.

One thing that would make it better is if the examples in AllExamples were grouped by subject / TLD as it'd make navigating the rather long list of projects much easier.

It would also be nice to have the ability to potentially re-write the dproj files on request to use an installed CGE (like the planned getit one) rather than re-building it each time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants