New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to overwrite isGeometryValid function. #50
Comments
Hi @caseycesari , have you had a chance to look over this yet? |
Hi @hparkertt. Thanks for the ping. I haven't had a chance yet. Realistically, I'm hoping to wrap up all the open PRs and issues by the end of the year. |
Hey @caseycesari , just checking in again. Let me know if you need anything! |
Hi @caseycesari , any word on this? |
Hello @hparkertt Many apologies for the delay. Truly trying to get to this soon, and make a release. |
Running this in NodeJS, I seem to be unable to overwrite this function to provide a custom implementation (as suggested by the comment). Here is a snippet of what I'm trying to do:
This appears to be a scoping issue. You can set the function on the
GeoJSON
object, but that does not change the function used internally. I've tested this with a fewconsole.log
statements. For example:In geojson.js:
Maybe the
isGeometryValid
function should be included in theGeoJSON.defaults
object, allowing for it to be overwritten as part of theparams
parameter?The text was updated successfully, but these errors were encountered: