Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse settings mutate defined objects as argument #44

Open
colbyfayock opened this issue May 7, 2019 · 0 comments
Open

Parse settings mutate defined objects as argument #44

colbyfayock opened this issue May 7, 2019 · 0 comments

Comments

@colbyfayock
Copy link

If I create a predefined object for the second argument, it would be mutated unexpectedly by the second time I invoke parse.

For instance:

const GEOJSON_PARSE_SETTINGS = {
  'Point': [
    'x',
    'y'
  ],
  'LineString': 'line',
  'Polygon': 'polygon'
};
return GeoJSON.parse(data, GEOJSON_PARSE_SETTINGS);

First time around it works, however the second time around, after being invoked, the object getting passed in there is actually:

{doThrows: {…}, geom: {…}} // GEOJSON_PARSE_SETTINGS output

This of course is avoidable by spreading it or cloning it, but just found it unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant