Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not updating .crates2.json #1552

Open
ToBinio opened this issue Jan 3, 2024 · 5 comments
Open

not updating .crates2.json #1552

ToBinio opened this issue Jan 3, 2024 · 5 comments

Comments

@ToBinio
Copy link

ToBinio commented Jan 3, 2024

it seems like cargo binstall does not update the .crates2.json

I found a command that says it would update but at least for me it does not

am I doing something wrong?

using version 1.4.9

@NobodyXu
Copy link
Member

NobodyXu commented Jan 3, 2024

Yes we decided not to update .crates2.json since it requires list of features enabled for the crate installed, binstall cannot provide that.

Perhaps we can simply leave the features to be empty?

@ToBinio
Copy link
Author

ToBinio commented Jan 3, 2024

just keeping the features empty sounds better to me than just not updating .crates2.json

tbh I don't even know where the feature data is used

btw, thanks for the quick response

@NobodyXu
Copy link
Member

NobodyXu commented Jan 3, 2024

tbh I don't even know where the feature data is used

Yeah I'm not aware of any, perhaps it's for future extension and third-party cargo tools.

@passcod
Copy link
Member

passcod commented Jan 4, 2024

The problem was less the features array, which we did use to just leave empty, but these three fields:

pub profile: String,
pub target: String,
pub rustc: String,

which aren't optional as far as i could see (or they'd have been Option<String>) and we had no reasonable way to set correctly, so we used:

profile: "release",
target: fetcher.target(), // detected target or --target
rustc: "cargo-binstall 1.2.3",

but iirc that had some bad interactions elsewhere.

@NobodyXu
Copy link
Member

NobodyXu commented Jan 4, 2024

Is rustc used by any tool?

Can we just set to the rustc currently installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants