Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DropdownSkeleton missing helper text and caret #16430

Open
2 tasks done
alisonjoseph opened this issue May 10, 2024 · 2 comments
Open
2 tasks done

[Bug]: DropdownSkeleton missing helper text and caret #16430

alisonjoseph opened this issue May 10, 2024 · 2 comments
Labels
component: dropdown role: dev 🤖 severity: 3 User can complete task, and/or has a workaround type: bug 🐛

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented May 10, 2024

Package

@carbon/react

Package version

v11

React version

1.57.0

Description

DropdownSkeleton in React is missing an option for helper text, it also doesn't display the caret icon. (need to confirm with @carbon-design-system/design if this is a bug in code or in Figma)

React
Screenshot 2024-05-10 at 7 54 26 AM

Figma
Screenshot 2024-05-10 at 7 53 25 AM

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-dropdown--skeleton

Steps to reproduce

Compare Figma to React

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

@laurenmrice
Copy link
Member

I think design needs to do an audit of our skeleton state specs for all components that have them to try to make them more consistent. I believe we may be moving away from including the icons in the skeleton state, so the code is probably more accurate for now.

@alisonjoseph
Copy link
Member Author

alisonjoseph commented May 29, 2024

@laurenmrice makes sense. Do we want to add the helper text option to this skeleton state in code?

@alisonjoseph alisonjoseph added severity: 3 User can complete task, and/or has a workaround component: dropdown labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dropdown role: dev 🤖 severity: 3 User can complete task, and/or has a workaround type: bug 🐛
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

2 participants